Problem with UNSTRING of CSV data

chavinash2004 · New User Joined: 30 Jun 2010 Posts: 37 Location: hyderabad

Hi All,

I have input file with Header,Detail and Trailer as below:
H,20151208,4400,61581,12400,00000820,
D,8201,DELI/Total purchased,038201,233.52,
D,13920,Charge to account,13920,,233.52

If we observe the data in 3rd line vendor is not sending "," because record ends here. When i do UNSTRING WS-RECORD DELIMITED BY ','
first and second records which are having "," at end is coming properly but the 3rd record is not getting correctly.

I searched in google and this site as well but did not get the exact answer so posting again. Please some one help me on this.

Bill Woodger · Posted: Tue Dec 15, 2015 5:32 pm

Each of your D records has five commas. What, more exactly, is your problem?

Can you show the code?

chavinash2004 · New User Joined: 30 Jun 2010 Posts: 37 Location: hyderabad

Hi Bill,

Thanks for you quick reply. Actually I should 6 fields

Record # 1:
A --> D,
B --> 8201,
C --> DELI/Total purchased,
D --> 038201,
E --> 233.52,
F --> After comma no data will take it as spaces

Record # 2:
A --> D,
B --> 13920,
C --> Charge to account,
D --> 13920,
E -->
F -->

In record 2 E and F are getting spaces when i use UNSTRING WS-RECORD DELIMITED BY ','

Bill Woodger · Posted: Tue Dec 15, 2015 6:01 pm

You haven't shown your code, so we can't tell what the problem is.

chavinash2004 · New User Joined: 30 Jun 2010 Posts: 37 Location: hyderabad

Hi Bill,

SYSOUT of my Job is as below:

chavinash2004 · New User Joined: 30 Jun 2010 Posts: 37 Location: hyderabad

Hi Bill,

Sorry for multiple posts:
Cobol code as below:

Bill Woodger · Posted: Tue Dec 15, 2015 6:37 pm

Well, your UNSTRING looks fine.

The names you later give are not those used in the UNSTRING. Is that your problem? Do the -NUM fields get anyting MOVEd to them?

chavinash2004 · New User Joined: 30 Jun 2010 Posts: 37 Location: hyderabad

Hi Bill,

These fileds i used just for Display.

Bill Woodger · Posted: Tue Dec 15, 2015 7:40 pm

OK, show your field definitions please. In the mean time, change them to PIC X fields of the same size and re-run your code.

Also in your DiSPLAY put delmiters around each field (like > and <) so you can see for sure what is happening.

Look up the rules in the Language Reference for a MOVE from Alpha-numeric to Numeric.

chavinash2004 · New User Joined: 30 Jun 2010 Posts: 37 Location: hyderabad

Hi Bill,

Thanks a lot for looking into it.

All the fields are PIC X fields.

Bill Woodger · Posted: Tue Dec 15, 2015 8:35 pm

Well the same thing is happening. A numeric is right-justified.

That final field is, say 40 bytes long (from the start of that final piece of data to the end of the source field.

So, it is the eight right-most of those 40 bytes which will be processed by the UNSTRING. If you take off the JUST RIGHT (a Goldilocks Field) you'll see your data. In the wrong place.

Then with your new PIC X(8), UNSTRING delimited by SPACE INTO your-just-right-field.

RahulG31 · Active User Joined: 20 Dec 2014 Posts: 446 Location: USA

This must be happening because the length of WS-DTL-RECORD is greater than the length of the Value in that field.

So, If your input value is 39 bytes and the length of variable WS-DTL-RECORD is 60 bytes AND you haven't mentioned a delimiter for the last record; Then your last record will be counted till 60th byte.

Robert Sample · Posted: Tue Dec 15, 2015 8:59 pm

The issue isn't with the length but actually appears to be with the JUST RIGHT. I ran a test job with your data, with UNSTRING into the same fields you have and then the same fields WITHOUT the JUST RIGHT clause. With the JUST RIGHT clause, neither of the last two fields has any data for the second D record. Without the JUST RIGHT clause, the fifth variable for the second D record has spaces and the last variable has the 233.52 value.

Get rid of the JUST RIGHT on your UNSTRING variables. You can always use a MOVE to a JUST RIGHT variable (or at worst use reference modification to find the last byte of data and move the value to the rightmost positions of your end variable).

chavinash2004 · New User Joined: 30 Jun 2010 Posts: 37 Location: hyderabad

Hi Bill and Robert,
If i remove the JUST RIGHT it is working fine.

Thanks a lot for your help and valuable time.

Robert Sample · Posted: Wed Dec 16, 2015 2:26 am

Glad to hear you got it working!