Suggestions to improve code

Huzefa · New User Joined: 05 Dec 2006 Posts: 83 Location: Bangalore

I developed a REXX code to notify team when there are more than 200 jobs running in Queue or when a job takes CPU time more than 20.
Any suggestions to improve this code will be of use.

ofer71 · Posted: Tue Nov 24, 2009 5:47 pm

Try to add the NOMODIFY option.

O.

Huzefa · New User Joined: 05 Dec 2006 Posts: 83 Location: Bangalore

i really appreciate that.

Pedro · Posted: Tue Nov 24, 2009 9:18 pm

Have you tried to run it?

1. I think you need a SLEEP statement within your loop. Otherwise, it will run continuously with no waiting. That is, the loop will execute 1000s of times each second. If you ever get more than 200 jobs, it will generate many, many messages before the team can respond. Your program may turn into a denial of service attack on yourself because a flood of messages will prevent you from doing any work (do not try this at home).
<update>I think you should wait several minutes before each iteration.

2. You have some setup statements that can be done before FOREVER statement. Likewise, you have some cleanup that can be done after the last END.

3. It is not clear why you need this:

Huzefa · New User Joined: 05 Dec 2006 Posts: 83 Location: Bangalore

Hi,

Thanks a lot for your response.

My bad, did not try testing with DO FOREVER LOOP.

1. Wil chk SLEEP statement.

2. ok.

3. Good Catch.I was trying to get individual columns from sdsf and forgot to remove it.

Huzefa · New User Joined: 05 Dec 2006 Posts: 83 Location: Bangalore

How does this look?

RC=ISFCALLS("ON")
ISFPREFIX='USERID*'
ISFCOLS="JNAME JOBID CPU "
Do Forever
ADDRESS SDSF "ISFEXEC ST (NOMODIFY"
IF ISFROWS > 200 THEN CALL NOTIFY_TEAM
ADDRESS SDSF "ISFEXEC DA (NOMODIFY"
DO IX=1 TO ISFROWS
IF CPU.IX > 20 THEN CALL NOTIFY_TEAM
END

CALL SYSCALLS ON
ADDRESS SYSCALL
"SLEEP" 900
CALL SYSCALLS OFF

End
RC=ISFCALLS("OFF")

expat · Posted: Wed Nov 25, 2009 1:15 pm

Would it not be better to submit the job every 10-15 minutes rather than hog an initiator all of the time, thus preventing anyone else using that initiator.

Huzefa · New User Joined: 05 Dec 2006 Posts: 83 Location: Bangalore

Thanks for suggestion. If we get to put this job in production, will definitely put forward this idea.

Pedro · Posted: Wed Nov 25, 2009 10:30 pm

Huzefa · New User Joined: 05 Dec 2006 Posts: 83 Location: Bangalore

I have the sleep statement inside "Do forever" so the pgm dose not chk sdsf unnecessarily. I want the pgm to chk sdsf once in 15 mins.

dick scherrer · Posted: Thu Nov 26, 2009 10:44 am

Hello,

You need to implement as Expat has suggested. . .

What you have now is unacceptable on every well-managed system i've ever seen. What you have is another of the things that can be done, but should not be done. All this method does is waste resources pretty much forever. . .

Taking an initiator permanently out-of-service is not acceptable.

Pedro · Posted: Thu Nov 26, 2009 9:05 pm

Your rexx program seems to be a poor man's system health checker. If this is part of your site's system management plan, you should be able to start the rexx program as a started task. Or if there is a shortage of initiators, then define another for this purpose.