Writing the same file in Main program and Subprogram

vishalbshah · New User Joined: 01 Dec 2006 Posts: 61 Location: Pune

Hi ,

I am having a error file, my Main program and subprograms are sharing this error file , I want to write errors from mainprogram as well as from subprogram.

I have coded same SELECT and FD statements in Main program as well as in Subprogram.

I have OPEN file in Mainprogram and written some records over there , when I am in to Subprogram I am just writing the record in file , I am getting SOC4 while executing WRITE Statement in Sub program as the FD record name is not having address in Sub program.

Can some one please, suggest how should I solve this issue?

dbzTHEdinosauer · Posted: Tue Aug 30, 2011 2:23 pm

create a 3rd module,
which will contain the only FD for this file.
remove the FD from your mainmodule and sub-module.
only purpose is to write to error file.
create a copybook to use a linkage between your mainprogram and your subprogram,
input elements:

text to write
function code
- WRITE
- CLOSE

output elements:

return code
- ok
- not ok
error text (file status)

write module should maintain an internal flag to determine if file is open or not.
when write function-code - module should open the file if not open then write.
when close function-code - module should close file if open.

dynamically CALL this module from mainprogram and subprogram.

also, you will have a module that can be used by new modules.

Bill Woodger · Posted: Tue Aug 30, 2011 2:59 pm

dbz's way is the way to go.

I don't feel a need not to do an open. The more "logic" there is, the easier it can be to spot errors through illogic use in the message module. Although in this case, it is all enormously simple. Important to check all the codes from file access and NOT call this module if you find a problem :-)

dbzTHEdinosauer · Posted: Tue Aug 30, 2011 5:33 pm

forgot to mention that the mainmodule should CALL this new module with
a CLOSE functioncode just before GOBACK (or STOP RUN if that is the level of your shop).

vishalbshah · New User Joined: 01 Dec 2006 Posts: 61 Location: Pune

Bill Woodger · Posted: Tue Aug 30, 2011 5:46 pm

The message writing is a technical thing, nothing to do with your business requirement, so no need to even think of complicating your code for the business function with some sort of weird "opening/closing, who knows when) sort of stuff.

Keep It Simple. Do it in the module. Called from main and sub-program. You then also have something, as dbz has already pointed out, that you can use in other programs, either directly or as a "clone". Makes the other programs less complex, more standard, better control/knowledge of where errors are written, etc.

Bill O'Boyle · Posted: Tue Aug 30, 2011 5:49 pm

In VS/COBOL II version 3, EXTERNAL FILES were introduced. Documentation can be found in your applicable Programming Guide and/or Language Reference Guide for your applicable COBOL version/release.

Mr. Bill