To identify spaces in between alphabets/numbers

vardhan0007 · Posted: Tue Jan 10, 2012 5:31 pm

Hi,

I have requirement to check few scenarios listed below.

01 WS-VAR PIC X(08)

I should validate the above variable,

i)It should not be ZEROS --->Taken care

e.g., 0000000

ii)should not be spaces----->Taken care

iii)Should not have any spaces between numbers of aplhabets.--->Need suggestions

e.g., 12 34567---->I should display error message
ab cdefg----->I should display error message

I am trying to validate each byte by byte using PERFORM. Is there any better way that I can do it?

Thanks
Vardhan

Bill Woodger · Posted: Tue Jan 10, 2012 5:42 pm

Have a look at INSPECT TALLYING.

Marso · Posted: Tue Jan 10, 2012 9:04 pm

Can you have spaces at the beginning or at the end?

Bill O'Boyle · Posted: Tue Jan 10, 2012 9:56 pm

Use the TALLY special-register (initialize to ZERO first), with the INSPECT TALLYING as Bill has suggested.

However, once the INSPECT is complete and TALLY is non-zero, then what?

Do you need to reformat the data, such as left-justified with low-order SPACES or right-justified with high-order SPACES or just a simple notification via a DISPLAY will suffice?

Mr. Bill

Chiranjeevi9 · New User Joined: 14 Dec 2011 Posts: 11 Location: India

As Bill Suggested INSPECT with TALLYING is enough for this scenario.

EX: INSPECT WS-VAR TALLYING COUNT-1 FOR ALL SPACES.

If COUNT-1 greaterthan ZERO means, found spaces in your cobol item(WS-VAR). So DISPLAY your error message when the COUNT-1 > ZERO.

Marso · Posted: Wed Jan 11, 2012 3:28 pm

Bill Woodger · Posted: Wed Jan 11, 2012 3:53 pm

So right Marso.

Bill O'Boyle · Posted: Thu Jan 12, 2012 8:01 am

If you need to reformat the data, review this previous post -

www.ibmmainframes.com/viewtopic.php?p=143786&highlight=#143786

Mr. Bill

vardhan0007 · Posted: Thu Jan 19, 2012 11:57 am

Hi All,

Thank you for the replies. Below is my code.

05 WS-NEW-KYWD PIC X(08).

01 WS-NEW-KEYWORD
05 WS-NEW-KEYWORD OCCURS 8 INDEXED BY WS-IDX PIC X.

MOVE WS-NEW-KYWD TO WS-NEW-KEYWORD

INSPECT WS-NEW-KYWD TALLYING WS-CNT FOR ALL SPACES

MOVE 0 TO WS-FLG
MOVE 0 TO WS-ZERO-CNT

IF WS-CNT < 8
COMPUTE WS-CNT = 8 - WS-CNT
SET WS-IDX TO 1
PERFORM UNTIL WS-IDX > WS-CNT
IF WS-NEW-KEYWORD (WS-IDX) = ZERO
ADD 1 TO WS-ZERO-CNT
END-IF
IF WS-NEW-KEYWORD (WS-IDX) = SPACE
MOVE 1 TO WS-FLG
END-IF

SET WS-IDX UP BY 1
END-PERFORM
DISPLAY 'WS-FLG:' WS-FLG UPON CONSOLE
IF (WS-FLG = 1 OR ( WS-CNT = WS-ZERO-CNT ))
DISPLAY '** PLEASE ENTER VALID DERIVED KEYWORD **'

END-IF
END-IF

Bill Woodger · Posted: Thu Jan 19, 2012 3:35 pm

If leading/trailing blanks are not valid, you have overcomplicated things by sticking to your byte-at-a-time approach.

lindovaldolpn · New User Joined: 25 Feb 2010 Posts: 16 Location: Brazil

It´s a another way
-------------------

01 WS-VAR PIC X(08)
77 BYTE1 PIC X VALUE SPACES.
77 BYTE2 PIC X VALUE SPACES.

UNSTRING WS-VAR
INTO BYTE1 DELIMITED BY SPACE
BYTE2
END-UNSTRING
IF BYTE2 NOT EQUAL SPACES
NOTE there are at least 1 byte with spaces
END-IF

Lindovaldo

Bill Woodger · Posted: Thu Jan 19, 2012 6:14 pm

Have you tried this with one or more trailing spaces? What happens?

What happens when you code this, an embedded space is found, and you go on to test the next value?

lindovaldolpn · New User Joined: 25 Feb 2010 Posts: 16 Location: Brazil

it´s new source file.

ID DIVISION.
PROGRAM-ID. PGM1.
ENVIRONMENT DIVISION.
CONFIGURATION SECTION.
DATA DIVISION.
WORKING-STORAGE SECTION.
77 TALLY PIC S9(4) COMP.
77 WS-VAR PIC X(08).
77 BYTE1 PIC X(01) VALUE SPACES.
77 BYTE2 PIC X(01) VALUE SPACES.
PROCEDURE DIVISION.
INICIO.
DISPLAY 'ACCEPT NUMBER'.
ACCEPT WS-VAR.
IF WS-VAR EQUAL 'EXIT' STOP RUN.
MOVE ZEROS TO TALLY.
UNSTRING WS-VAR DELIMITED BY SPACE
INTO BYTE1
BYTE2 TALLYING IN TALLY.
DISPLAY 'TALLY=' TALLY, ',WS-VAR=(' WS-VAR ')'.
IF TALLY GREATER 1
DISPLAY 'THERE ARE AT LEAST 1 BYTE'
ELSE
DISPLAY 'OK'.
GO INICIO.

When I run...

(SPLXWAA8XA) C:\COBOL>PGM1
ACCEPT NUMBER
12345678
TALLY=+0001,WS-VAR=(12345678)
OK
ACCEPT NUMBER
1 3 5 7
TALLY=+0002,WS-VAR=(1 3 5 7 )
THERE ARE AT LEAST 1 BYTE
ACCEPT NUMBER
2 4 6 8
TALLY=+0002,WS-VAR=( 2 4 6 8)
THERE ARE AT LEAST 1 BYTE
ACCEPT NUMBER
1 8
TALLY=+0002,WS-VAR=(1 8)
THERE ARE AT LEAST 1 BYTE
ACCEPT NUMBER
1
TALLY=+0002,WS-VAR=(1 )
THERE ARE AT LEAST 1 BYTE
ACCEPT NUMBER
EXIT

(SPLXWAA8XA) C:\COBOL>

I hope that it will be solve your problem.

Bill Woodger · Posted: Thu Jan 19, 2012 7:37 pm

Mmm...

So, you've changed your mind but want to keep it. You define two extra fields, populated (maybe) by UNSTRING, neither of which you use, just to provide an alternative to INSPECT TALLYING? Are you showing how it might be done on a PC, rather than a mainframe? Any-old-code-will-do, as long as the "right" answer pops out at the end?

And, of oourse, having been asked specifically about trailing space in your first "solution", you've tested this one with leading space, haven't you?

lindovaldolpn · New User Joined: 25 Feb 2010 Posts: 16 Location: Brazil

Ok, I agree with you.

I add an option using INSPECT, I think it is a better way.

MOVE ZEROS TO COUNT1
INSPECT WS-VAR TALLYING COUNT1 FOR ALL SPACE.
IF COUNT1 GREATER ZEROS
DISPLAY 'INSPECT - THERE ARE ' COUNT1 ' BYTE/S'
ELSE
DISPLAY 'INSPECT - OK'.

Mainframe with JES3

EDIT xxxxxxxx.STS.JOBS(JPGM1) - 01.01 Columns 00001 00072
Command ===> Scroll ===> CSR
****** ***************************** Top of Data ******************************
000001 //F334021T JOB '9999999,1,SPEC',F334097,CLASS=D,MSGCLASS=S
000002 //*MAIN SYSTEM=A4
000003 //*
000004 //STEP1 EXEC PGM=PGM1
000005 //STEPLIB DD DSN=F334021.STS.LINKLIB2,DISP=SHR
000006 //SYSPRINT DD SYSOUT=*
000007 //SYSOUT DD SYSOUT=*
000008 //SYSIN DD *
000009 12345678
000010 1 3 5 7
000011 2 4 6 8
000012 1 8
000013 1
000014 EXIT
****** **************************** Bottom of Data ****************************

. . . . . . . . . . . . . . . . . . . . . . . . . . .
Jobs Resources Devices Tools Filter View Options Help
-------------------------------------------------------------------------------
F334021T JOB22679 < .STEP1 .SYSOUU > Line 1 of 21
Command ===> Scroll ===> CSR
Current Find Text: Dataset 1 of 1
---+----1----+----2----+----3----+----4----+----5----+----6----+----7----+---->
ACCEPT NUMBER
TALLY=00001,WS-VAR=(12345678)
OK
INSPECT - OK
ACCEPT NUMBER
TALLY=00002,WS-VAR=(1 3 5 7 )
THERE ARE AT LEAST 1 BYTE
INSPECT - THERE ARE 0004 BYTE/S
ACCEPT NUMBER
TALLY=00002,WS-VAR=( 2 4 6 8)
THERE ARE AT LEAST 1 BYTE
INSPECT - THERE ARE 0004 BYTE/S
ACCEPT NUMBER
TALLY=00002,WS-VAR=(1 8)
THERE ARE AT LEAST 1 BYTE
INSPECT - THERE ARE 0006 BYTE/S
ACCEPT NUMBER
TALLY=00002,WS-VAR=(1 )
THERE ARE AT LEAST 1 BYTE
INSPECT - THERE ARE 0007 BYTE/S
ACCEPT NUMBER

Lindovaldo

vardhan0007 · Posted: Fri Jan 20, 2012 8:47 am

Hi Bill,

01 WS-COUNT-BLANKS-IN-NEW-KEYWRD COMP PIC S9(4).
88 WS-CBNK-THERE-ARE-SOME-BLANKS VALUE +1 THRU +7.
88 WS-CBNK-THERE-ARE-ONLY-BLANKS VALUE +8.

INSPECT WS-NEW-KYWD
TALLYING WS-COUNT-BLANKS-IN-NEW-KEYWRD
FOR SPACE

IF ( WS-CBNK-THERE-ARE-SOME-BLANKS )
OR ( WS-NEW-KEYWD EQUAL TO ZERO )
DISPLAY '** PLEASE ENTER VALID DERIVED KEYWORD **'
END-IF

The above code will even restrict me to enter any space in the field. i.e.,
12345 <---last 3 bytes spaces
12 <---Last 6 bytes spaces
1 <---Last 7 bytes spaces.

Yes I am already handling all spaces and zeros in another paragraph.

This is an IMS DC program hence I am using UPON CONSOLE statement for my debugging purpose.

Thanks again.

-Vardhan