Problem while Moving Values from 2D array to WS 1D array

soumen2255 · New User Joined: 25 Jun 2008 Posts: 24 Location: Pune

Hi,

I am facing Problem while Moving Values from Copybook 2D array to WS 1D .

My copybook layout is -

Bill Woodger · Posted: Sun Jun 26, 2011 3:00 pm

soumen2255 · New User Joined: 25 Jun 2008 Posts: 24 Location: Pune

soumen2255 · New User Joined: 25 Jun 2008 Posts: 24 Location: Pune

Hi,

I tried This

Bill Woodger · Posted: Sun Jun 26, 2011 3:23 pm

Your profile says "Cobol", it is three years and one day since you registered.

Are you unfamiliar with indexes?

Look at your definitions. One table defines one index, the idiotic and meaningless s1, and the other table (perforce) defines another, equally idiotic name, z1. When referencing data indexed by s1, you have to use s1. When referencing data indexed by z1, you have to use z1. In the same statement, you need to use both indexes, on the appropriate fields.

You do not define the indexes seperately yourself. The compiler defines the storage for the index because you say "INDEXED BY".

If you are new to indexes, check out the manuals really thoroughly. Do some practice usage. Read the manuals again. More practice. Then, when you understand what is wrong with what you have done and said, get back to this program. If we just give you the answers, you are going to make countless other errors through lack of knowledge. Put in the understanding first, then you'll know how to do the code.

And use meaningful data-names! Including indexes!

Let us know how you get on.

dbzTHEdinosauer · Posted: Sun Jun 26, 2011 3:36 pm

i added/changed a little of your code. try this:

soumen2255 · New User Joined: 25 Jun 2008 Posts: 24 Location: Pune

Bill Woodger · Posted: Sun Jun 26, 2011 3:59 pm

Mmmm.... or just wait long enough and the working code pops up. :-)

Now dbz has done that for you, a couple of other things.

You have "> 50". What does the 50 mean? Size of your table. If you reference in more than one place in your program (often the case) you have 50 scattered through your procedure division. Then you want to change the size of your table (or, more importantly, someone else does as you have moved on to new "development only" projects) and you've made the maintenance more difficult. Plus, someone has to look at all the 50's in the program, to see if they refer to your tables or to something else, and make sure they only change the 50's referring to your table.

Same with the "1" as your 2nd-level index. In business terms, what does the first row mean? If nothing particular, at least come up with a name that indicates it is the first row.

seagull · New User Joined: 28 May 2007 Posts: 24 Location: Dublin

When you want to use the same instance for both tables, try using a subscript instead of using the indexes. It makes coding easier.

Bill Woodger · Posted: Thu Aug 04, 2011 4:31 pm

Are you saying "easier" to mix subscripts and indexes in the same program? Or to abandon indexes altogether? Or just in selected programs so you have a mix in your system?

That all makes it "easier" for whom?

dbzTHEdinosauer · Posted: Thu Aug 04, 2011 4:34 pm

seagull · New User Joined: 28 May 2007 Posts: 24 Location: Dublin

I was meaning use subscripts in an example like this, where you want to use the same occurrence in more than one table. That way, you only have to worry about one variable to get to the correct instance of both tables.

Use indexes as appropriate, and subscripts where appropriate. Subscripts are probably easier to understand for programmers starting out. The issue is that a lot of people are never taught how indexes actually work, and just assume they work in the same way as subscripts.

dbzTHEdinosauer · Posted: Thu Aug 04, 2011 4:47 pm

show me an appropriate use of a sub-script.....

literal subscripts (which generate the address at compile time) are the most efficient.

then indexes

then subscripts.

if you are going to use subscripts make sure that they are comp (binary).

people use subscripts because they are second rate coders.
They do not know how to properly use perform varying with multiple until phrases.

dick scherrer · Posted: Fri Aug 05, 2011 2:43 am

Hello,

seagull · New User Joined: 28 May 2007 Posts: 24 Location: Dublin

Bill Woodger · Posted: Fri Aug 05, 2011 3:40 pm

We are meandering off-topic a little.

I don't mind subscripts, in the obvious situation pointed out earlier by Dick.

I do mind mixing subscripts and indexes in the same program or the same system. Fortunately this would be rare, as the "subscript-only" sites won't allow indexes and the "index" sites would'nt want to use subscripts, particularly with the risk of causing confusion. One or the other per system, and I keep quiet.