|
View previous topic :: View next topic
|
| Author |
Message |
kbrahma
New User
Joined: 08 Oct 2007
Posts: 38
Location: Delhi
|
|
|
|
Hi All,
I am writting a sample REXX which is suppose to insert lines when it finds some predifined word in a member. To make things interesting I wanted to run the exec through the command line of the member opened (EDIT or VIEW mode). I collected the Dataset and the member name by parsing ZSCREENI variable (Thanks to this forum).
To insert the contents on the member, I am re-writting everything and when the word is found (in this case "Fruits"), it will start another loop to write what I want to and then continue writting the other stuff until the end of member is reached.
But that's when the problem starts, I have to major bugs in the program...
1. When I run the EXEC, it gives me a
IKJ56246I DATA SET KUSHAL.TEST.DATASET NOT ALLOCATED, FILE IN USE error for OUTDD. I know two files containing the same dataset name cannot be opened at a single time, but I want to edit the same file. Is there another way to do it?
2. Insted of editing that same file, the program WORKS but it writes the file to my REXX Lib (where the EXEC resides) instead with the member name SYSEXEC.
Here's my code,
| Code: |
/* REXX */
address ISPEXEC "VGET ZSCREENI SHARED"
parse var ZSCREENI . . . . . . . . . . file'('member')' . . rest
file = strip(file,"L"," ")
line.1 = "Mango"
line.2 = "Apple"
line.3 = "Banana"
"allocate shr fi(indd) dataset('"file"("member")')"
"allocate shr fi(outdd) dataset('"file"("member")')"
a = 0
Do forever
"execio 1 diskr indd"
If rc <> 0 Then Leave
Parse Pull jcl
Push jcl
"execio 1 diskw outdd"
if a = 0 then
do
If pos("Fruits",jcl) > 0 then
Do n = 1 to 3
Push line.n
"execio 1 diskw outdd"
a = 1
End
end
End
"execio 0 diskr indd (finis"
"execio 0 diskw outdd (finis"
|
I know it's a pretty lengthy post but I hope I was clear enough. Any kind of help would be appreciated.
TIA
Kushal |
|
| Back to top |
|
 |
enrico-sorichetti
Superior Member
Joined: 14 Mar 2007
Posts: 10873
Location: italy
|
|
|
|
since You want to write a REXX script to handle data inside EDIT or VIEW
the proper approach is to write an EDIT MACRO
there simply using
Address ISREDIT "(DATASET) = DATASET"
Address ISREDIT "(MEMBER) = MEMBER"
will make available the info You ask for with less troubles
ZSCREENI is the wrong <tool> for the environment and the actions You describe
look here for a working edit macro example
ibmmainframes.com/viewtopic.php?t=25947&highlight=isredit+member+dataset |
|
| Back to top |
|
|
kbrahma
New User
Joined: 08 Oct 2007
Posts: 38
Location: Delhi
|
|
|
|
The EDIT MACRO is not an option for me,
I have tried using the EDIT MACRO earlier but it gives me a ++20++ RC.
The code:
| Code: |
/*REXX*/
trace i
Address ISREDIT "(DSN) = DATASET"
Address ISREDIT "(MEM) = MEMBER"
say dsn
say mem |
Gives me:
| Code: |
3 *-* Address ISREDIT "(DSN) = DATASET"
>L> "(DSN) = DATASET"
+++ RC(20) +++
4 *-* Address ISREDIT "(MEM) = MEMBER"
>L> "(MEM) = MEMBER"
+++ RC(20) +++
5 *-* say dsn
>L> "DATASET"
DATASET
6 *-* say mem
>L> "MEM"
MEM |
When the same code works in others site (in this forum). |
|
| Back to top |
|
|
superk
Global Moderator
Joined: 26 Apr 2004
Posts: 4652
Location: Raleigh, NC, USA
|
|
|
|
| Your macro is missing the "ISREDIT MACRO" keyword. |
|
| Back to top |
|
|
kbrahma
New User
Joined: 08 Oct 2007
Posts: 38
Location: Delhi
|
|
|
|
Tried that as well....
add this in the trace output above...
| Code: |
*-* "ISREDIT MACRO"
>L> "ISREDIT MACRO"
+++ RC(20) +++ |
|
|
| Back to top |
|
|
daveporcelan
Active Member
Joined: 01 Dec 2006
Posts: 792
Location: Pennsylvania
|
|
|
|
Not only are are you missing the "ISREDIT MACRO", your concept of trying to read the dataset(member) you are in as input, then write it again as output is flawed.
The concept of an EDIT Macro is to make the change while EDITING the member (any sequential file) itself.
To run an edit macro DO NOT type TSO first, just the macro name (in my example: newlines fruit) where fruit is the keyword to add the lines after.
Keep in mind this is just one way to accomplish your task.
| Code: |
/* REXX EXEC TO INSERT LINES AFTER A FOUND WORD */
"ISREDIT MACRO (WORDIN)"
/* LIST Of WORDS TO INSERT */
LIST. = ''
LIST.1 = 'MANGO'
LIST.2 = 'APPLE'
LIST.3 = 'BANANA'
"ISREDIT FIND" WORDIN "FIRST"
FINDRC = RC
IF FINDRC > 0 THEN DO
SAY 'WORD -' WORDIN 'NOT FOUND'
SIGNAL EXIT99
END
/* FINE LINE NUMBER WHERE FOUND */
"ISREDIT (LINE1,COL1) = CURSOR"
/* LOOP TO INSERT ALL FROM ARRAY */
PTR = 1
DO UNTIL LIST.PTR = ''
"ISREDIT LINE_AFTER" LINE1 "= '"LIST.PTR"'"
PTR = PTR + 1
LINE1 = LINE1 + 1
END
EXIT99: NOP
EXIT
|
|
|
| Back to top |
|
|
daveporcelan
Active Member
Joined: 01 Dec 2006
Posts: 792
Location: Pennsylvania
|
|
|
|
I negleted to mention clearly that the name of my edit macro is NEWLINES and the word FRUIT is the keyword to add the lines after.
You may also notice there is no effort to identify the dataset name or member name because it is not neeeded.
I am adding the lines after the keyword, period. |
|
| Back to top |
|
|
kbrahma
New User
Joined: 08 Oct 2007
Posts: 38
Location: Delhi
|
|
|
|
Thanks a lot Dave... I kind of knew the reading the input and writing the output idea was flawed, but I couldn't think of anything else specially since I am unable to use the EDIT Macros. For every Macro call, I am getting a RC of ++(20)++
e.g.
| Code: |
7 *-* "ISREDIT MACRO (WORDIN)"
>L> "ISREDIT MACRO (WORDIN)"
+++ RC(20) +++ |
or
| Code: |
15 *-* "ISREDIT FIND" WORDIN "FIRST"
>L> "ISREDIT FIND"
>V> "//*"
>O> "ISREDIT FIND //*"
>L> "FIRST"
>O> "ISREDIT FIND //* FIRST"
+++ RC(20) +++ |
If there's some other way of doing it other than EDIT MACRO's, I'll be happy to know. I had to resort to my technique because I couldn't use the EDIT macro for some unknown reason.
P.S. If anyone has a explanation on why I can't use the EDIT MACROs, I'll be happy to know, but I guess I will leave that for a new post. |
|
| Back to top |
|
|
dick scherrer
Moderator Emeritus
Joined: 23 Nov 2006
Posts: 19244
Location: Inside the Matrix
|
|
|
|
Hello,
It may help if you post the complete code including the EDIT macro.
| Quote: |
| I had to resort to my technique because I couldn't use the EDIT macro for some unknown reason. |
Just a suggestion, but in the future, when something does not work, it will be in your best interest to learn why. You might still choose an alternative, but knowing why something does not work is quite important. . . |
|
| Back to top |
|
|
daveporcelan
Active Member
Joined: 01 Dec 2006
Posts: 792
Location: Pennsylvania
|
|
|
|
How are you invoking your edit macro?
To run an edit macro DO NOT type TSO first, just the macro name (in my example: newlines fruit) where fruit is the keyword to add the lines after.
When I type TSO first I get the same rc(20) you did. |
|
| Back to top |
|
|
kbrahma
New User
Joined: 08 Oct 2007
Posts: 38
Location: Delhi
|
|
|
|
I agree completely Dick, I would love to know why my EDIT macro is failing and I did some research on my own in this forum. I found a person who had the same problem and the suggestion given by one of the posters was to contact the System Admin to get it sorted as ++(20)++ is a system failure.
Dave, I am invoking it by "ISREDIT MACRO" command
I usually test a part of the code before implementing it in the main program, so I tested the code:
| Code: |
"ISREDIT MACRO"
Address ISREDIT "(DSN) = DATASET"
Address ISREDIT "(MEM) = MEMBER"
say dsn
say mem |
When it couldn't determine the name of the dataset and member, I moved on to ZSCREENI, which worked for me, so I stuck to that. |
|
| Back to top |
|
|
dick scherrer
Moderator Emeritus
Joined: 23 Nov 2006
Posts: 19244
Location: Inside the Matrix
|
|
|
|
Hello,
Completely a guess, but might there be some problem with a library. . . 
Are any of your co-workers able to execute an edit macro? |
|
| Back to top |
|
|
daveporcelan
Active Member
Joined: 01 Dec 2006
Posts: 792
Location: Pennsylvania
|
|
|
|
kbrahma,
That is not what I mean.
Let me get basic here...
Please read every thing I type, ignore nothing.
I put my edit macro NEWLINES (the macro I posted earlier in a pds called SHARED.MACRO.LIB(NEWLINES).
I used this pds because our systems folks has this library concatenated in our tso logon proc. This way my macro can be found.
You can tell it is an edit macro because of the "ISREDIT MACRO" after the /* REXX */ and before any other ISREDIT commands.
I am now a different member (or any sequential file) in EDIT or VIEW.
I want to add my list after a specific word.
On the command line I type: newlines fruit and then press enter. This is how I INVOKED (ran, executed, put your own verb here) my macro.
I did not type tso first.
My macro inserted the lines after the word 'fruit'.
I have been reading this forum for more than two years. I have learned many tricks and tips.
I usually do not post and I know why. It is very fustrating. I do not know how Dick, Enrico, Expat, SuperK, Anuj and the other senior (by experience, not age) members do it.
kbrahma, you said many times 'I can not run edit macros'.
I find this very hard to believe. This is the most important thing you need to figure out.
If I was a betting man, I would guess you are typing TSO newlines on the command line. |
|
| Back to top |
|
|
daveporcelan
Active Member
Joined: 01 Dec 2006
Posts: 792
Location: Pennsylvania
|
|
|
|
Dick,
He can execute the code itself since he is getting the rc(20) and the first error he mentioned earlier.
For this reason, I do not think it is a library thing.
I think it is the TSO thing.
kbrahma,
Your idea about executing on part of your code at a time, can get you into trouble.
If it doesn't work, you do not know if it is a problem with the code you are testing, or what you left out. You may have created an evironmental error. |
|
| Back to top |
|
|
dick scherrer
Moderator Emeritus
Joined: 23 Nov 2006
Posts: 19244
Location: Inside the Matrix
|
|
|
|
Hi Dave,
| Quote: |
| He can execute the code itself since he is getting the rc(20) and the first error he mentioned earlier. |
Well, the rexx starts but it sounds like every attempt to execute a macro fails. . .
I'm still curious if anyone else can successfuly invoke an edit macro on that system. . .
I don't know just what goes on "under the covers", but i suspect that an edit macro needs things that a non-edit-macro bit of code does not (how's that for a really deep technical concept  ).
| Quote: |
| It is very fustrating. I do not know how Dick, Enrico, Expat, SuperK, Anuj and the other senior (by experience, not age) members do it. |
Ah, um, one post at a time?
Kind words. . . Much appreciated 
d |
|
| Back to top |
|
|
Pedro
Global Moderator
Joined: 01 Sep 2006
Posts: 2547
Location: Silicon Valley
|
|
|
|
| kbrahma, you have not adequately showed us how you invoke your macro. What do you type and what key do you press to execute it? |
|
| Back to top |
|
|
Pedro
Global Moderator
Joined: 01 Sep 2006
Posts: 2547
Location: Silicon Valley
|
|
|
|
| Quote: |
| If I was a betting man, I would guess you are typing TSO newlines on the command line. |
my bet also.
Using TSO newlines throws you out of the edit session and then the ISREDIT macro instructions will not work.
From Dave's example:
| Code: |
| "ISREDIT MACRO (WORDIN)" |
I prefer this form:
| Code: |
Address ISREDIT
"MACRO (WORDIN)" |
|
|
| Back to top |
|
|
enrico-sorichetti
Superior Member
Joined: 14 Mar 2007
Posts: 10873
Location: italy
|
|
|
|
| Quote: |
| It is very fustrating. I do not know how Dick, Enrico, Expat, SuperK, Anuj and the other senior (by experience, not age) members do it. |
as far as I am concerned, also by age 
we do it by having the MACRO stored in a pds part of the SYSPROC or SYSEXEC concatenation
as described also in the instructions in the my rexx macro posted in the link in my previous post
-- once upon a time there were some gotchas in using sysexec and many preferred just to put everything in the SYSPROC concatenation |
|
| Back to top |
|
|
Kjeld
Active User
Joined: 15 Dec 2009
Posts: 365
Location: Denmark
|
|
|
|
I have a working edit macro, and it start like this:
| Code: |
/* Rexx ***********************************************************/
address ISPEXEC
'ISREDIT MACRO'
trace off
|
I think you miss the
statement to get the ISREDIT commands strings directed towards the ISPF environment.
Look up the 'address' statement in the REXX manual to learn how to issue commands to different environments. |
|
| Back to top |
|
|
kbrahma
New User
Joined: 08 Oct 2007
Posts: 38
Location: Delhi
|
|
|
|
| daveporcelan wrote: |
If I was a betting man, I would guess you are typing TSO newlines on the command line. |
You hit the nail right on the head there. My apologies for not getting what you were saying from the start. I was using TSO to invoke my exec and that's why I was getting a RC+++(20)+++.
I understand it is frustrating to explain things to us newbies when you know that the problem we come up with are very basic. I won't come up with an excuse for this, but this as I said at the start is just a learning project for me. In the end I am happy I came away with the knowledge but I am tad bit dissapointed to learn that we are such a pain in the rear end.. 
I assure you that I will try a bit more harder from my side before posting any more questions in this forum.
Thank you all for your valuable replies and a special thanks to daveporcelan for demystifying my "failing" Edit macro. |
|
| Back to top |
|
|
daveporcelan
Active Member
Joined: 01 Dec 2006
Posts: 792
Location: Pennsylvania
|
|
|
|
| Quote: |
| but I am tad bit dissapointed to learn that we are such a pain in the rear end. |
No worries, I am glad you got to the 'bottom' of it.
It appears you have learned not only how to run an edit macro, but also how to provide the proper information to get your question answered. |
|
| Back to top |
|
|
Pedro
Global Moderator
Joined: 01 Sep 2006
Posts: 2547
Location: Silicon Valley
|
|
|
|
| Quote: |
I think you miss the
Code:
address ISPEXEC
statement to get the ISREDIT commands strings directed towards the ISPF environment. |
Sorry, that is wrong. (If it works for you, I suppose ISPF somehow tolerates it). The macro instructions should not get directed to ISPF itself, but should be directed to the edit environment.
I think this is recommended:
| Code: |
/* Rexx ***********************************************************/
address ISREDIT
'MACRO'
trace off |
|
|
| Back to top |
|
|
Kjeld
Active User
Joined: 15 Dec 2009
Posts: 365
Location: Denmark
|
|
|
|
I have found that all 3 formats:
| Code: |
address ISPEXEC
'ISREDIT MACRO'
'ISREDIT MACRO' /* No previous address statements issued */
address ISREDIT
'MACRO'
|
works and yields the same results at my installation. I guess the last format is the recommended if explicitly issuing edit macro commands.
The middle one uses the default host command environment for the invocation (TSO) and will find the ISREDIT command environment anyway.
However, a site can modify the modules called or possibly add or delete REXX host command environment from the installation, as specified in the TSO REXX reference manual. |
|
| Back to top |
|
|
Pedro
Global Moderator
Joined: 01 Sep 2006
Posts: 2547
Location: Silicon Valley
|
|
|
|
In retrospect, there is probably not a very big difference between any of your examples. There are probably minor differences in the amount of parsing and the module call sequence.
Yet, I still prefer the more specific specification. |
|
| Back to top |
|
|
|
|
