cobol string concatination

b4uthammi · New User Joined: 21 Feb 2005 Posts: 14 Location: hyderabad

Hai ,
Please give me the solution for below logic.

i have input file record structure like this

05 EMPLOYEE-NAME.
10 FIRST-NAME PIC X(12).
10 MIDDLE-INIT PIC X.
10 LAST-NAME PIC X(17).

i want to concatinate like last-name,middle-init,last-name
but the problem is my input for LAST-NAME is varying from 4 to 17 like
"james "
"john j cranley "
"J M LOGAN INC "

sample output records:
last-name,middle-init,last-name
"JOHN J CRANLEY CO,,"

"MUTSCHELLER,JAMES,F"

"SOO,ROGER,"

TR

Bitneuker · Posted: Tue Jan 02, 2007 5:38 pm

Hi TR,

Must be a training question 'cause an identical one was posted and solved right here. Just do some searching in the forum and very often the solution is there.

b4uthammi · New User Joined: 21 Feb 2005 Posts: 14 Location: hyderabad

Hi Bitneuker,
Thanks for your early response.The posted query is not a training one.it is the one which i need to implement in one of my program(project).

yes, i have gone through the solution which is in the forum,but mine is different .

in the out put record i need to place ',' explicitly after every field.

Sample input data:

05 EMPLOYEE-NAME.
10 FIRST-NAME PIC X(12) VALUE 'JAME'
10 MIDDLE-INIT PIC X VALUE 'D'.
10 LAST-NAME PIC X(17) VALUE 'W A U & ASSOCIATE' .

expected output::

"W A U & ASSOCIATE,JAME,D"

THANKS,
TR

Bitneuker · Posted: Tue Jan 02, 2007 6:19 pm

Have some reading about the string statement over here. The manual is at the forum (topline -> manuals)

William Thompson · Posted: Tue Jan 02, 2007 6:49 pm

Bitneuker · Posted: Tue Jan 02, 2007 7:00 pm

vijayamadhuri · Active User Joined: 06 Apr 2005 Posts: 180

You would have to code it as
STRING WS-first-name WS-mid-name WS-last-name
DELIMITED BY SIZE
INTO EMPLOYEE-NAME

Irrespective of the length of u r last name this will work.

If you want to put comma then

just define another structure of EMPLOYEE-NAME

as EMPLOYEE-NAME1

05 EMPLOYEE-NAME1.
10 FIRST-NAME PIC X(12).
10 ws-comma pic x(1) value ','.
10 MIDDLE-INIT PIC X.
10 ws-comma pic x(1) value ','.
10 LAST-NAME PIC X(17). EMPLOYEE-NAME1.

Move employee-name fields to employee-name1 fields and then use STRING.

William Thompson · Posted: Tue Jan 02, 2007 8:17 pm

DavidatK · Posted: Wed Jan 03, 2007 6:53 am

TR,

The problem comes in determining the length of the significant characters in the string. This is where the ?INSPECT? and ?FUNCTION REVERSE? come in. Once you have the lengths of the individual strings then it?s pretty straight forward with ?STRING? or as priyesh.agrawal did with reference modification moves.

Take a look again at the post priyesh.agrawal made. The link is posted by Bitneuker Tue Jan 02, 2007 5:08 pm

b4uthammi · New User Joined: 21 Feb 2005 Posts: 14 Location: hyderabad

Hi David,

It is working fine except for ','.
My requirement is after every string i want ','.

output::
last-name first-name middle-init
BEARDEN WARREN H

expected ouput:
BEARDEN,WARREN,H

Thanks in advance
TR

Arun Raj · Posted: Wed Jan 03, 2007 1:37 pm

Hi b4uthammi

Your problem is already solved.MOVE ',' TO wherever you need

Thanks'
Arun

William Thompson · Posted: Wed Jan 03, 2007 2:28 pm

Arun Raj · Posted: Wed Jan 03, 2007 3:51 pm

Hi

You can try STRING also

b4uthammi · New User Joined: 21 Feb 2005 Posts: 14 Location: hyderabad

Hai all,

My problem got resolved.now it is working fine with agarwal logic after few modifications.

Thanks
TR

William Thompson · Posted: Wed Jan 03, 2007 5:07 pm

Bitneuker · Posted: Thu Jan 04, 2007 2:04 am

prav_06 · Posted: Fri Jan 05, 2007 4:09 pm

Concat Strings ... Here is a simple way to do it check out the below pgm
ID DIVISION.
PROGRAM-ID. PRAV.
DATA DIVISION.
WORKING-STORAGE SECTION.
01 INREC.
05 WS-VAR1 PIC X(4) VALUE 'KING'.
05 WS-VAR2 PIC X(2) VALUE 'K'.
05 WS-VAR3 PIC X(9) VALUE 'MARSHALL'.
PROCEDURE DIVISION.
PARA1.
DISPLAY WS-VAR1 ',' WS-VAR2 ',' WS-VAR3.
STOP RUN.

output would be
KING,K,MARSHALL

DavidatK · Posted: Fri Jan 05, 2007 11:28 pm

prav_06 · Posted: Mon Jan 08, 2007 1:28 pm

Hi David ,
I had tried running the pgm in my Mainframe machine it yeilded me an output

Arun Raj · Posted: Mon Jan 08, 2007 4:29 pm

Hi Thamilzan

The problem was not just to display it in a particular way.It was to concatenate three variables(that might be having trailing spaces or spaces in between) into a single one and i think he has already got the solution.